Fix mouse selection on resize #260
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the containerBoundingRect on every mouseDown event. This ensures the container coords are correct on page resize and hopefully fixes issue agentcooper#259 . This does add some extra overhead, but less than re-rendering the whole element on a page resize.
Replaced `;` with `&&` for chaining copying commands. This means copy-styles will return a fail code if it doesn't copy to esm correctly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a simple fix for issue #259 . Before, the
containerBounderRectinMouseSelectionwas only being set whenevercontainerCoordswas first called. Since MouseSelection doesn't re-mount on a resize,containerBoundingRectdoesn't get reset to null and then re-initialised, breaking the calculated coords.All this fix does is set
containerBoundingRectto the latest clientRect whenever mouseDown is called. This adds some extra unnecessary overhead, but the alternative is resetting the variable on resize from the PdfHighlighter or remounting the MouseSelection entirely. I may have forgotten another way, though 馃槀.I also just made a very small change to
build:copy-stylesto make it safer.