improve perf 3-5x by avoiding re-instantiating date formatter #356
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Querying workouts was taking an unexpectedly long time, so did a perf trace, saw that this code was the culprit:
Modified the code and re-ran my project and saw huge savings.
TBH not sure if this needs more extensive testing (are there unit tests?), but feedback is welcome.
BEFORE:
AFTER:
Fixes # (issue)
Type of change
Please delete options that are not relevant.
Checklist: