🚧 WIP: V2 #334
🚧 WIP: V2 #334
Conversation
- Samples are now encodable to String for bridging to react native
- Moved queries to a different file
- Fixed issue with metadata predicate
- Deleted old rn bindings - Created bindings for new core
- Moved sample type parameter to parameter object - Interval and anchor date parameters are now available in react native
- Fixed typo - Fixed issue when saving sample - Added unit field to quantity sampl- Fixed typo - Fixed issue when saving sample - Added unit field to quantity sample
| import Foundation | ||
| import HealthKit | ||
|
|
||
| public protocol HealthKitType: RawRepresentable { |
There was a problem hiding this comment.
question: Is the rawValue always string? If yes I suggest changing it to RawRepresentable<String>
| public struct QuantityQuery { | ||
| let startDate: Date? | ||
| let endDate: Date? | ||
| let isUserEntered: Bool? |
There was a problem hiding this comment.
question: What does isUserEntered == nil represent?
There was a problem hiding this comment.
Samples manually added by the user on Health app. I'll think in a better name 😅
There was a problem hiding this comment.
I see, but what's the difference between false and nil here?
There was a problem hiding this comment.
Oh sorry lol
if set to false, it will only get samples that were not manually added. If nil it won't matter.
There was a problem hiding this comment.
ohh I see makes sense now, my instinct on those situations is to go with an OptionSet
struct FetchMode: OptionSet {
let rawValue: Int
static var userEntered: Self { .init(rawValue: 1 << 0) }
static var automaticallyEntered: Self { .init(rawValue: 1 << 1) }
}then you can use it like QuantityQuery(fetchMode: .userEntered) or QuantityQuery(fetchMode: [.userEntered, .automaticallyEntered])
Bool? is totally fine as well, in fact is probably a better choice if you plan on exposing this struct to objc
| import HealthKit | ||
|
|
||
| public protocol HealthKitType: RawRepresentable { | ||
| var type: HKSampleType { get } |
There was a problem hiding this comment.
suggestion: Since this protocol is not directly available in objective-c maybe you could add this HKSampleType as a primary associated type to the protocol. So you don't need to cast the type when using a concrete type.
I totally understand not going for it if the compiler is giving you grief for using PATs, an alternative could be having a computed property that does the type casting on the concrete types.
enum QuantityType {
/// Don't use this directly. Use `quantitySampleType` instead.
public var type: HKSampleType { ... } // I wonder if there's a way to use @available here to help
public var quantitySampleType: HKQuantityType { type as! HKQuantityType }| var core: HealthKitCore? | ||
|
|
||
| @objc | ||
| func initHealthKit(_ read: Array<String>, write: Array<String>, resolve: @escaping RCTPromiseResolveBlock, reject: @escaping RCTPromiseRejectBlock) { |
There was a problem hiding this comment.
potential-issue: looks like is not possible to request workout permissions since this won't try to create it. I think you might have to go for the imperative code approach here
var readTypes: [any HealthKitType] = []
for identifier in read {
guard let readType = QuantityType(rawValue: identifier) ?? WorkoutType(rawValue: identifier) else { continue }
readTypes.append(readType)
}There was a problem hiding this comment.
Workout is not properly exported yet, currently working on that 😅
| var core: HealthKitCore? | ||
|
|
||
| @objc | ||
| func initHealthKit(_ read: Array<String>, write: Array<String>, resolve: @escaping RCTPromiseResolveBlock, reject: @escaping RCTPromiseRejectBlock) { |
There was a problem hiding this comment.
nitpick:
nitpick:
| func initHealthKit(_ read: Array<String>, write: Array<String>, resolve: @escaping RCTPromiseResolveBlock, reject: @escaping RCTPromiseRejectBlock) { | |
| func initHealthKit(_ read: [String], write: [String], resolve: @escaping RCTPromiseResolveBlock, reject: @escaping RCTPromiseRejectBlock) { |
- Fixed typo on statistical query - Addded config to fix error warning on exmaple app - Exported ids filter for quantity query
- Added missing resolve on save quantity query
…-to-health-kit-core chore: Add documentation to HealthKitCore module
…-workout-samples feat: Add metadata to workout samples
|
hey folks, I was just wondering if this is the current progress? https://github.com/agencyenterprise/react-native-health/projects/2 |
This is draft PR for a complete overhaul of react-native-health library. This code is a work in progress and is subject to change at any moment. You are welcome to test it but this is not stable or production ready.