Skip to content

Commit

Permalink
Use npm ci instead of npm install
Browse files Browse the repository at this point in the history
Refs #394

Because we have the `package-lock.json` checked in, `npm ci` is
favorable.  If one desires to add or update a package, the intended
workflow is to change the `package.json`, execute `npm install
locally, and check in the appropriate changes in the lock file.
  • Loading branch information
lukasjuhrich committed Jul 27, 2020
1 parent af14af6 commit 5d28a9a
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion docker/dev/container/hooks/init/20_npm
Original file line number Diff line number Diff line change
Expand Up @@ -8,4 +8,4 @@ if [[ -d node_modules ]] && $(shopt -s nullglob dotglob; files=(node_modules/*);
exit
fi

npm install
npm ci
2 changes: 1 addition & 1 deletion docker/prod.Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ RUN /opt/pycroft/venv/bin/pip wheel --wheel-dir /opt/pycroft/wheel -r requiremen

# Download JS/CSS dependencies
COPY --chown=pycroft:pycroft package.json .
RUN npm install
RUN npm ci

# Build Pycroft wheel
COPY --chown=pycroft:pycroft . .
Expand Down

0 comments on commit 5d28a9a

Please sign in to comment.