Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ag-grid-solid: Run onMount before createEffect #7100

Open
wants to merge 1 commit into
base: latest
Choose a base branch
from

Conversation

sin-ack
Copy link

@sin-ack sin-ack commented Sep 29, 2023

Otherwise we access gridOptions before it's assigned.

Otherwise we access `gridOptions` before it's assigned.
@StephenCooper
Copy link
Member

Hi @sin-ack,

Thanks for this. Do you think you could provide a reproduction of this issue so that we can validate your changes?

@sin-ack
Copy link
Author

sin-ack commented Oct 2, 2023

Sure, here's a StackBlitz example where the issue is exhibited: https://stackblitz.com/edit/solidjs-templates-iyvhby?file=src%2FApp.tsx

You should see "Error!" in the output window, and the error message will be printed to the console.

I couldn't reproduce it at first, but the specific issue seems to be with putting columnDefs behind a function (we need this in our project for i18n). If I use static columnDefs then the issue isn't exhibited. I'll look into it further tomorrow to see why this is the case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants