AG-11385 Initial ProxyInteractionService #1570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olegat
force-pushed
the
AG-11385/initial_proxyInteractionService
branch
from
039db73
to
1418674
Compare
Also add stubbed ProxyInteractionService class which will be responsive for creating hidden DOM elements that represent the chart for a11y.
This file is generic enough and doesn't need to know about the scene.
The BBox class is quite complex, but a lot of functionalities only need small subset of this class. Examples: - RegionManager only needs `containPoint` and `width * height` (area). - FocusIndicator only needs `x, y, width, height`. - QuadtreeNodeExact only needs `collidesBBox` and `containsPoint`. - QuadtreeNodeNearest only needs `distanceSquared` and `containsPoint`. This cleanup will hopefully make code maintanance easier.
olegat
force-pushed
the
AG-11385/initial_proxyInteractionService
branch
from
a38afb2
to
037c39c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://ag-grid.atlassian.net/browse/AG-11385