AG-11385 Proxy DOM elements #1557
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olegat
force-pushed
the
AG-11385/proxy_dom_elements
branch
3 times, most recently
from
b2634dc
to
252012f
Compare
This is prep-work for #1557. The hidden proxy-buttons will need update the focusIndicator bounds. But we don't want to need up with a circular dependency where RegionManager depends on DOMManager and vice-versa. So separate this out.
Proxy buttons ignore mouse events (pass through), but can still be interacted with using the keyboard.
The Chart class calls the Legend.data setter when toggling legend items on or off. So make the proxyButton element part of the MarkerLabel node instead of the datum.
olegat
force-pushed
the
AG-11385/proxy_dom_elements
branch
from
252012f
to
6cb689c
Compare
|
Closing, there's a new improve PR: #1574 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://ag-grid.atlassian.net/browse/AG-11385