QR Code Sponsor : export csv #1497
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerlio
force-pushed
the
feat/ajout-qr-code-reader
branch
from
8c01ccb
to
fbbc1ee
Compare
jerlio
force-pushed
the
feat/export-qr-codoes-csv
branch
from
cab6857
to
2352064
Compare
agallou
reviewed
Apr 27, 2024
| try { | ||
| $sponsorTicket = $this->checkSponsorTicket($request); | ||
| } catch (\Exception $e) { | ||
| $this->addFlash('error', $e->getMessage()); |
There was a problem hiding this comment.
si c'est une exception technique ça me semble risqué de renvoyer le message à l'utilisateur vu que ça catche toutes les \Exception, on pourrait avoir des infos qu'on ne souhaiterais pas voir exposées
jerlio
force-pushed
the
feat/ajout-qr-code-reader
branch
2 times, most recently
from
d491932
to
376a276
Compare
agallou
reviewed
May 8, 2024
| @@ -0,0 +1,31 @@ | |||
| import QrScanner from "./qr-scanner.min.js"; | |||
There was a problem hiding this comment.
j'ai l'impression qu'il y a des soucis sur la PR, des changements de la PR d'avant s'affichent. ces changements sur le qr code scanner ne devrait-ils pas ne pas apparaitre ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scan de QR Codes pour les sponsors du forum
Partie 4 : export CSV des personnes dont le badge a été scanné.