Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QR Code Sponsor : on ajoute le qr code reader #1496

Open
wants to merge 2 commits into
base: feat/command-generation-qr-code-visiteurs
Choose a base branch
from

Conversation

jerlio
Copy link
Contributor

@jerlio jerlio commented Apr 24, 2024

Scan de QR Codes pour les sponsors du forum

Partie 3 : ajout du lecteur de QR Code en javascript, qui récupère le code flash/12345 fourni dans le qrcode, et redirige vers le path fourni dans le twig avec le code 12345 en paramètre.

@jerlio jerlio self-assigned this Apr 24, 2024
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pour les dépendances on a des dépendances js includes comme celle-ci :

"tablefilter": "^0.5.42",
dans le package.json, puis intégrées via webpack. Est-ce que ça n'éviterais pas de la commiter ?

@jerlio jerlio force-pushed the feat/ajout-qr-code-reader branch from fbbc1ee to d491932 Compare May 7, 2024 22:10
@jerlio jerlio force-pushed the feat/ajout-qr-code-reader branch from d491932 to 376a276 Compare May 7, 2024 22:11
@@ -208,3 +208,4 @@ venue_speaker.expenses.intro: |
Le package speaker prend en charge le remboursement des frais de transport, sur base d'un trajet en 2nde classe ou classe économique.<br />
Envoyez-nous vos justificatifs (par exemple, une facture de billet de train ou une copie du billet), ainsi que votre RIB/IBAN.<br />
Utilisez le formulaire ci-dessous pour nous envoyer ces informations (au format PDF). Vous pouvez nous envoyer plusieurs fichiers.
sponsor.qr_code_scanner.disclaimer: Merci de valider avec le ou la participante qu'il ou elle accepte que vous scanniez son badge !
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Petite suggestion non genrée :

Suggested change
sponsor.qr_code_scanner.disclaimer: Merci de valider avec le ou la participante qu'il ou elle accepte que vous scanniez son badge !
sponsor.qr_code_scanner.disclaimer: Merci de valider que l'autre personne accepte que vous scanniez son badge !

"Lancer l'outil de scan de QR Codes": "Run QR Code Scanner"
sponsor.qr_code_scanner.disclaimer: Please confirm with the participant that he or she agrees to you scanning their badge!
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

En version non genrée :

Suggested change
sponsor.qr_code_scanner.disclaimer: Please confirm with the participant that he or she agrees to you scanning their badge!
sponsor.qr_code_scanner.disclaimer: Please confirm that the participant agrees for you to scan their badge!

Comment on lines +14 to +16
<span id="success-code">Code valide ! Patientez...</span>
<span id="bad-code">QR Code incorrect !</span>
<span id="cam-qr-result">None</span>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pas de traduction prévue ici ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants