Add compose Modifier parameter to PdfRendererViewCompose (#102)

afreakyelf · Jan 5, 2024 · 227588c · 227588c
1 parent ca7ca7d
commit 227588c
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 5 deletions.
diff --git a/app/src/main/java/com/rajat/sample/pdfviewer/ComposeActivity.kt b/app/src/main/java/com/rajat/sample/pdfviewer/ComposeActivity.kt
@@ -33,17 +33,21 @@ class ComposeActivity : ComponentActivity() {
                     modifier = Modifier.fillMaxSize(),
                     color = MaterialTheme.colorScheme.background
                 ) {
-                    MyPdfScreenFromUrl(download_file_url2)
+                    MyPdfScreenFromUrl(
+                        url = download_file_url2,
+                        modifier = Modifier.fillMaxSize()
+                    )
                 }
             }
         }
     }
 }
 
 @Composable
-fun MyPdfScreenFromUrl(url: String) {
+fun MyPdfScreenFromUrl(url: String, modifier: Modifier = Modifier) {
     val lifecycleOwner = LocalLifecycleOwner.current
     PdfRendererViewCompose(
+        modifier = modifier,
         url = url,
         lifecycleOwner = lifecycleOwner,
         statusCallBack = object : PdfRendererView.StatusCallBack {
@@ -91,4 +95,4 @@ fun GreetingPreview() {
     AndroidpdfviewerTheme {
         MyPdfScreenFromUrl("https://css4.pub/2015/textbook/somatosensory.pdf")
     }
-}
+}
diff --git a/pdfViewer/src/main/java/com/rajat/pdfviewer/compose/PdfRendererCompose.kt b/pdfViewer/src/main/java/com/rajat/pdfviewer/compose/PdfRendererCompose.kt
@@ -1,6 +1,7 @@
 package com.rajat.pdfviewer.compose
 
 import androidx.compose.runtime.Composable
+import androidx.compose.ui.Modifier
 import androidx.compose.ui.platform.LocalLifecycleOwner
 import androidx.compose.ui.viewinterop.AndroidView
 import androidx.lifecycle.LifecycleOwner
@@ -11,6 +12,7 @@ import java.io.File
 
 @Composable
 fun PdfRendererViewCompose(
+    modifier: Modifier = Modifier,
     url: String? = null,
     file: File? = null,
     headers: HeaderData = HeaderData(),
@@ -34,6 +36,7 @@ fun PdfRendererViewCompose(
         },
         update = { view ->
             // Update logic if needed
-        }
+        },
+        modifier = modifier
     )
-}
+}