Check the isPlaying flag of the component when calling component behaviors #5516
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR fixes a regression introduced in #5478, which was noticed by @vincentfretin in #5515. In short, behaviours would be marked for removal when they belong to a component that is currently having their
tick
/tock
called. This works fine in case an entity is removed or if the removed components have already been called, but fails if they are yet to be called.This PR simply changes the check in
callComponentBehaviors
from.el.isPlaying
to.isPlaying
as components with behaviours have this flag. Generally it matches the.el.isPlaying
state, unless the component hasn't (fully) initialized yet or is removed from an entity. Those are precisely the cases where the bug could surface.The related unit tests required some changes in setup as they used Components that weren't completely initialized or inline defined behaviours.
Fixes/supersedes #5515
Changes proposed:
tick
andtock
on components that are currently playing