Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional device check for Ipad Pro on Safari #5502

Merged
merged 11 commits into from
Apr 1, 2024
Merged

Conversation

Drkjr92
Copy link
Contributor

@Drkjr92 Drkjr92 commented Mar 24, 2024

Description:
Issue raised in #5494.

The issue: iPadOS User Agent in Safari is same as on MacOS Catalina.

User case:

There are some use cases in which it is necessary to know whether it is a mobile device, e.g. a help dialogue that describes either touch or mouse/keyboard gestures.

Changes proposed:

  • In isTablet() we want to extend the ipad check for those special cases where the user agent from the Ipad is labeled "MacOS"

Test also added and Results are shown below:

image

src/utils/device.js Outdated Show resolved Hide resolved
@Drkjr92 Drkjr92 requested a review from dmarcos March 31, 2024 21:50
@dmarcos
Copy link
Member

dmarcos commented Apr 1, 2024

Thanks so much! Congrats on your first contribution

@dmarcos dmarcos merged commit a6ec417 into aframevr:master Apr 1, 2024
1 check passed
@Drkjr92
Copy link
Contributor Author

Drkjr92 commented Apr 1, 2024

Thank you!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants