Switch unit tests to WebXR and fix vive(-focus)-controls #5452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Needs rebase |
mrxz
force-pushed
the
webxr-controls-tests
branch
from
1cc0328
to
0fbf6ca
Compare
|
@dmarcos Rebased |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Split off from #5451 with the focus of letting the various controls unit tests target the WebXR behaviour. This PR also includes fixes for the Vive and Vive Focus controls.
Changes proposed:
vive-controls] Fix incorrectthumbstickaxis withtouchpadvive-focus-controls] Add WebXR support