New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proposed fix for 5411 #5412

Draft

diarmidmackenzie wants to merge 1 commit into aframevr:master from diarmidmackenzie:issue5411-possible-fix

Contributor

diarmidmackenzie commented Dec 12, 2023 •

edited

Description:

Changes proposed:

In VR mode, when no mouse is available, prevent cursor from firing a "mouseenter" event, as follows:

on entering VR, set a flag this.mouseAvailable to false
on detection of a mouse move or click event, set this.mouseAvailable to true
use this.mouseAvailable to determine whether ot not to so an early return on detection of a raycaster intersection.

This is intended to allow use of a mouse in "VR mode" for e.g. cases such as desktop full screen.

This PR is still a draft. I haven't yet:

run UTs
added UTs
done any live testing

If a fix along these lines is wanted, I'll take care of the above, and submit for review. For now awaiting feedback either here or in #5411.


          Proposed fix for 5411

d136709

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment