Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hand-controls: rotates models to match WebXR definition (fix #4848) #5261

Merged
merged 2 commits into from
Mar 20, 2023

Conversation

DougReeder
Copy link
Contributor

Description:
Fixes #4848
The WebXR standard now defines the grip space such that a cylinder held in a closed hand points along the Z axis. The models currently have such a cylinder point along the X-Axis.

Changes proposed:
There are two approaches

  1. rotate the mesh in code, as done here
  2. edit the GLB files

I'm fine with either, but I lack knowledge of 3D tools (such as Blender) to implement the second approach.

@DougReeder
Copy link
Contributor Author

@dmarcos dmarcos changed the title hand-controls: rotates models to match WebXR definition hand-controls: rotates models to match WebXR definition (fix #4848) Mar 20, 2023
@dmarcos
Copy link
Member

dmarcos commented Mar 20, 2023

Thanks!. I think we have to check for sceneEl.hasWebXR before applying the offset so WebVR (Firefox) still works as before.

I would also add a comment in the offset:

// The WebXR standard defines the grip space such that a cylinder held in a closed hand points along the Z axis. ./
// The models currently have such a cylinder point along the X-Axis.
var modelOrientationXOffset = sceneEl.hasWebXR ? xxx : 0;
...

@dmarcos
Copy link
Member

dmarcos commented Mar 20, 2023

Thank you!

@dmarcos dmarcos merged commit 5b29ac2 into aframevr:master Mar 20, 2023
@DougReeder DougReeder deleted the grip-space branch April 8, 2023 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hand tracking controls model needs update
2 participants