Ensure a-entity rotation Euler has YXZ order even without rotation co…

…mponent (#5513) Co-authored-by: Noeri Huisman <mrxz@users.noreply.github.com>
aframevr · Apr 8, 2024 · 763b3fe · 763b3fe
1 parent f2b7a83
commit 763b3fe
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/components/rotation.js b/src/components/rotation.js
@@ -10,8 +10,7 @@ module.exports.Component = registerComponent('rotation', {
   update: function () {
     var data = this.data;
     var object3D = this.el.object3D;
-    object3D.rotation.set(degToRad(data.x), degToRad(data.y), degToRad(data.z));
-    object3D.rotation.order = 'YXZ';
+    object3D.rotation.set(degToRad(data.x), degToRad(data.y), degToRad(data.z), 'YXZ');
   },
 
   remove: function () {

diff --git a/src/core/a-entity.js b/src/core/a-entity.js
@@ -32,6 +32,7 @@ class AEntity extends ANode {
     this.isEntity = true;
     this.isPlaying = false;
     this.object3D = new THREE.Group();
+    this.object3D.rotation.order = 'YXZ';
     this.object3D.el = this;
     this.object3DMap = {};
     this.parentEl = null;