Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build dependencies, three and react-select #708

Merged
merged 4 commits into from May 22, 2024

Conversation

vincentfretin
Copy link
Contributor

Mainly maintenance update just to keep things up to date, while I'm doing this in all my other projects.
Please not that some build dependencies update require now node 18.x (previous nodes version are not maintained anyway, node 20.x is the current LTS)
Updating three from 0.145.0 to 0.161.0 for GLTFExporter, exporting the example scene still works great, no change, bundle size increased by 7kB because of this update.
Updating react-select from 5.7.0 to 5.8.0, no real change for the usage we do here.

Bundle size
before: 489K
after: 493K

@vincentfretin
Copy link
Contributor Author

@dmarcos there is still a very old and unmaintained ghpages package in the dependencies. I don't think we use it. Do you use any of the npm run ghpages/preghpages/deploy scripts when you update https://aframe.io/aframe-inspector/examples/ ?
If not, we can remove that stuff.

@dmarcos
Copy link
Member

dmarcos commented May 22, 2024

thanks!

@dmarcos dmarcos merged commit 575c910 into aframevr:master May 22, 2024
1 check passed
@vincentfretin vincentfretin deleted the update-build-dependencies branch May 22, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants