Suma20240202 #565
Open
Suma20240202 #565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…face Controller menu. Also standarddize alpha threshold buttons to check boxes
… slider on SUMA Surface Controller menu, albeit with an extra "A" checkbox in the far right panel.
…UMA Surface Controller menu.
…urfCont structure.
…of the global vairable, SurfCont->AlphaThresh. Also removed some dead code
…t change the colormap. Must start with "A" box checked and with threshold zero.
…ike it was drawn with a paintbrush. Need to add refresh when "A" and "B" buttons are clicked.
…as due to trying to process overlapys, with ShowMode == SW_SurfCont_DsetViewXXX, for alpha thresholds. Also got rid of some no longer useful pfintf statements.
…actual brain sample instead of just a toy. Still has some issues. The opacity does not fall off very fast and the colors are dubious. But can toggle back and forth between "A" ective and "A" not active.
…el and made quadratic the default.
…verlay appeared much thicker, when threshold zero or low and "A" box checked.
…op overlay. This seems to avoid the problems where "A" first checked when threshold non-zero and when user changes the colormap. Probably needs more testing and debugging
…accurate in cases where the columns (subricks) of the data set are set to the defaults. I.e. (ITB)=(000)
…t threshold to zero, copied color map and then reset threshold to original. Threshold correct for sliding bar but not for edit box. Beta: May node a boundary mode if some of its neighbors are above, and some below, the threshold. Also added function from DrawROI but effect not seen so far. That part needs debugging
…arts look darker on dark areas due to original mixing with underlying gray
…y not be seen, on the brain, and the program to always crash with the toy examples
…ET changed or when colormap changed while DETs have been changed from zero.
… debugging output.
…o original after its being set to zero to update full color map. Code needs tidying up
…causing confusion. Also check with toy examples and it does not crash on my Ubuntu system
…of "A" box which will require more work
…mentation of "A" box for DriveSuma in C code
mrneont
reviewed
Feb 8, 2024
There was a problem hiding this comment.
@OtagoHarbour : I think the new line 38 could use updating:
D$SUMA_DIR/riveSuma -com viewer_cont -key '.'
->
$SUMA_DIR/DriveSuma -com viewer_cont -key '.'
… by removing debugging code
… Outline working to be sure. But "B" is checked by driver
…re the program crashes with multiple surface objects
…, when color map or intensity range changes. This is often necessary to prevent colors being messed up in suprathreshold regions.
…epts one of yes/no/Linear/Quadratic with yes implying Quadratic and (Linear, Quadratic) implying yes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New branch. Alpha seems to work and no toy example crashes observed on Ubuntu system