HeaderMatchingFilter: Gracefully handle missing headers #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Notmuch can raise a NullPointerException when trying to read a non-existent header from a message. Gracefully handle this in the HeaderMatchingFilter by just aborting processing when encountering such an error.
|
Hello, This look like improvement to me but I would like this code to test covered, |
|
Guillaume Seren ***@***.***> writes:
Hello,
thank you for the patch.
This look like improvement to me but I would like this code to test covered,
do you mind adding a test for this ?
Sure, PTAL :)
|
Signed-off-by: Toke Høiland-Jørgensen <toke@toke.dk>
tohojo
force-pushed
the
optional-headers
branch
from
6422475
to
38797f6
Compare
|
Hey @tohojo , It is LGTM 👍 |
GuillaumeSeren
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notmuch can raise a NullPointerException when trying to read a non-existent header from a message. Gracefully handle this in the HeaderMatchingFilter by just aborting processing when encountering such an error.