Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add readthedocs.yaml, drop codecov, update python versions, fix doc building #333

Merged
merged 7 commits into from Jun 15, 2023

Conversation

flokli
Copy link
Member

@flokli flokli commented Jun 14, 2023

@codecov
Copy link

codecov bot commented Jun 14, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (e696759) 46.93% compared to head (e813832) 46.93%.

❗ Current head e813832 differs from pull request most recent head f0a7539. Consider uploading reports for the commit f0a7539 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #333   +/-   ##
=======================================
  Coverage   46.93%   46.93%           
=======================================
  Files          30       30           
  Lines        1078     1078           
=======================================
  Hits          506      506           
  Misses        572      572           
Flag Coverage Δ
unittests 46.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Otherwise this fails in CI, at least for Python 3.11 with the following error:

```
ERROR: setuptools==44.0.0 is used in combination with setuptools_scm>=6.x

Your build configuration is incomplete and previously worked by accident!
setuptools_scm requires setuptools>=45

This happens as setuptools is unable to replace itself when a activated build dependency
requires a more recent setuptools version
(it does not respect "setuptools>X" in setup_requires).

setuptools>=31 is required for setup.cfg metadata support
setuptools>=42 is required for pyproject.toml configuration support

Suggested workarounds if applicable:
 - preinstalling build dependencies like setuptools_scm before running setup.py
 - installing setuptools_scm using the system package manager to ensure consistency
 - migrating from the deprecated setup_requires mechanism to pep517/518
   and using a pyproject.toml to declare build dependencies
   which are reliably pre-installed before running the build tools
```
This now fails with

```
{'detail': ErrorDetail(string='Unable to locate build via Github Actions API. Please upload with the Codecov repository upload token to resolve issue.', code='not_found')}
```
@flokli flokli changed the title add .readthedocs.yaml add readthedocs.yaml, drop codecov, update python versions, fix doc building Jun 14, 2023
@flokli flokli merged commit 51a5f61 into afewmail:master Jun 15, 2023
5 checks passed
@flokli flokli deleted the rtd-conf branch June 15, 2023 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant