Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix inconsistent vendoring #115

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

milahu
Copy link

@milahu milahu commented Aug 26, 2021

cd aether-core; go mod vendor

is needed to build from source on nixos

error was:

Building subPackage ./aether/backend
go: inconsistent vendoring in /build/aether-core:
        github.com/golang/protobuf@v1.2.0: is explicitly required in go.mod, but vendor/modules.txt indicates github.com/golang/protobuf@v1.3.1
        golang.org/x/crypto@v0.0.0-20180904163835-0709b304e793: is explicitly required in go.mod, but vendor/modules.txt indicates golang.org/x/crypto@v0.0.0-20190308221718-c2843e01d9a2
        golang.org/x/net@v0.0.0-20180826012351-8a410e7b638d: is explicitly required in go.mod, but vendor/modules.txt indicates golang.org/x/net@v0.0.0-20190603091049-60506f45cf65
        golang.org/x/sys@v0.0.0-20180905080454-ebe1bf3edb33: is explicitly required in go.mod, but vendor/modules.txt indicates golang.org/x/sys@v0.0.0-20190215142949-d0b11bdaac8a
        golang.org/x/text@v0.3.0: is explicitly required in go.mod, but vendor/modules.txt indicates golang.org/x/text@v0.3.2

        To ignore the vendor directory, use -mod=readonly or -mod=mod.
        To sync the vendor directory, run:
                go mod vendor

edit: now tests are failing

done: unable to open database file
STACK TRACE
aether-core/aether/services/logging/logging.go:73
aether-core/aether/backend/cmd/root.go:236
aether-core/aether/backend/eventhorizon_test/eventhorizon_test.go:41
_testmain.go:61
runtime/proc.go:225

2021/08/26 16:30:30 unable to open database file
FAIL    aether-core/aether/backend/eventhorizon

problem: in the nix build env, the test cannot create $HOME/.config/Air Labs/A-UnitTest/backend/AetherDB.db
which on nixos is /homeless-shelter/.config/Air Labs/A-UnitTest/backend/AetherDB.db
and sqlite fails on mkdir of /homeless-shelter
-> set $HOME to /tmp

i broke some of the eventhorizon tests

=== RUN   TestPostInsert_Success
    eventhorizon_test.go:168: Insertion failed, not all data requested has been inserted. expected 1000 - actual 0
--- FAIL: TestPostInsert_Success (0.35s)

=== RUN   TestPruneDB_WithinLocalMemory_Success
    eventhorizon_test.go:202: Event horizon accidentally cleared data that was within the network memory. expected 1000 - actual 0
--- FAIL: TestPruneDB_WithinLocalMemory_Success (0.37s)

=== RUN   TestPruneDB_WithinLocalMemory_TooBigDb_Success
    eventhorizon_test.go:228: Event horizon accidentally cleared data that was within the network memory. expected 2000 - actual 0
--- FAIL: TestPruneDB_WithinLocalMemory_TooBigDb_Success (1.37s)

=== RUN   TestPruneDB_ScaledModeGetsEnabled_Success
    eventhorizon_test.go:284: Event horizon did not stop deleting from within the network head when it should have. expected 1000 - actual 0
--- FAIL: TestPruneDB_ScaledModeGetsEnabled_Success (0.49s)

=== RUN   TestPruneDB_ScaledModeManuallySet_Success
    eventhorizon_test.go:305: Event horizon did not stop deleting from within the network head when it should have. expected 1000 - actual 0
--- FAIL: TestPruneDB_ScaledModeManuallySet_Success (0.42s)

FAIL
FAIL    aether-core/aether/backend/eventhorizon 3.494s
FAIL

@milahu
Copy link
Author

milahu commented Aug 27, 2021

last commit 53b6c8b on 2019-09-20, hmm ...

@Frigyes06
Copy link

Hello @milahu !
I too noticed that Nehbit is a bit too busy at his main job right now, and that's why I started a fork of Aether at https://github.com/Frigyes06/aether-app
I'm currently working on getting CI working. If you want, you could make a PR with your improvements to that repo or help with anything else. I'd greatly appreciate it!
Best,
Frigyes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants