New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Prepend token symbol #637
Conversation
Deployed to https://pr-637-aescan.stg.service.aepps.com |
As a followup I created one more refactor issue #639 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found that token symbol is not displayed in all places, for example for this account:
ak_xi7SnhwezGZR3PFdX4hHCkEdCBzeKTzqP5V77ybTpoMvraaVG
2024-01-03.12.52.39.mov
is this expected @janmichek ?
That's a good discovery. Found that and fixed. Forgot to mention that the thing you should check is the whole app in A/B comparison of values. Compared to this https://aescan.dev.service.aepps.com |
@janmichek the issue with icons has been fixed. But I've found another one. It seems that some Txs have more data that need additional tab/coverage: 2024-01-03.4.21.34.mov |
@Liubov-crypto I am not really sure what you wanted to show me. Could you rephrase it? |
@janmichek I meant additional column for the sent amount. It was different on dev, but now I see the same just with old design. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
0d96e4a
to
8ac88b1
Compare
Dependantly on the order, this needs to be accommodated after rebase #700 |
@michele-franchi can you take a look at this. please? |
ea54a8a
to
a3de39d
Compare
1527bdc
to
272e81e
Compare
The build stopped working. Let's continue here #809 |
Description
resolves #396
Demo
firefox_piVgkBSexo.mp4
Checklist: