Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Prepend token symbol #637

Closed
wants to merge 15 commits into from
Closed

feat: Prepend token symbol #637

wants to merge 15 commits into from

Conversation

janmichek
Copy link
Collaborator

@janmichek janmichek commented Dec 29, 2023

Description

resolves #396

Demo

firefox_piVgkBSexo.mp4

Checklist:

  • I have read and followed the Contributing Guide
  • add price label component and reuse over app

Copy link

@janmichek
Copy link
Collaborator Author

As a followup I created one more refactor issue #639

@janmichek janmichek requested review from Liubov-crypto and removed request for lukeromanowicz January 3, 2024 10:02
Copy link
Collaborator

@Liubov-crypto Liubov-crypto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found that token symbol is not displayed in all places, for example for this account:
ak_xi7SnhwezGZR3PFdX4hHCkEdCBzeKTzqP5V77ybTpoMvraaVG

ae1

2024-01-03.12.52.39.mov

is this expected @janmichek ?

@janmichek
Copy link
Collaborator Author

I found that token symbol is not displayed in all places, for example for this account: ak_xi7SnhwezGZR3PFdX4hHCkEdCBzeKTzqP5V77ybTpoMvraaVG

ae1
2024-01-03.12.52.39.mov

is this expected @janmichek ?

That's a good discovery. Found that and fixed.

Forgot to mention that the thing you should check is the whole app in A/B comparison of values. Compared to this https://aescan.dev.service.aepps.com

@Liubov-crypto
Copy link
Collaborator

I found that token symbol is not displayed in all places, for example for this account: ak_xi7SnhwezGZR3PFdX4hHCkEdCBzeKTzqP5V77ybTpoMvraaVG
ae1
2024-01-03.12.52.39.mov
is this expected @janmichek ?

That's a good discovery. Found that and fixed.

Forgot to mention that the thing you should check is the whole app in A/B comparison of values. Compared to this https://aescan.dev.service.aepps.com

@janmichek the issue with icons has been fixed.

But I've found another one. It seems that some Txs have more data that need additional tab/coverage:

2024-01-03.4.21.34.mov

@janmichek
Copy link
Collaborator Author

@Liubov-crypto I am not really sure what you wanted to show me. Could you rephrase it?
Does it really differ from the current state of dev? https://aescan.dev.service.aepps.com
What is the account id?

@Liubov-crypto
Copy link
Collaborator

@Liubov-crypto I am not really sure what you wanted to show me. Could you rephrase it? Does it really differ from the current state of dev? https://aescan.dev.service.aepps.com What is the account id?

@janmichek I meant additional column for the sent amount. It was different on dev, but now I see the same just with old design.

Copy link
Collaborator

@Liubov-crypto Liubov-crypto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@janmichek
Copy link
Collaborator Author

Dependantly on the order, this needs to be accommodated after rebase #700

@janmichek
Copy link
Collaborator Author

@michele-franchi can you take a look at this. please?

@janmichek
Copy link
Collaborator Author

The build stopped working. Let's continue here #809

@janmichek janmichek mentioned this pull request May 23, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prepend token symbol
2 participants