Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Top accounts #634

Closed
wants to merge 7 commits into from
Closed

feat: Top accounts #634

wants to merge 7 commits into from

Conversation

janmichek
Copy link
Collaborator

Description

resolves #616

  • The endpoint responds with top 200 accounts. Cannot be limited to 100. I think we can proceed with that
  • There is no entrypoint for the feature yet. So the only way to check the feature is to go to /top-accounts URL. The entripoint is a part of new menu here feat: New menu structure  #627

Demo

image

Checklist:

Copy link

Copy link
Collaborator

@Liubov-crypto Liubov-crypto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@janmichek I have questions:

  1. According to Top Accounts Info: The top accounts are the accounts with the highest balance of AE coins. But I can see in the list that many accounts have 0 balance now and the last Tx was 10 months ago or 1-2 year ago. Is this correct order?
2023-12-29.5.33.34.mov
  1. According to Add top accounts page #616 description A new table should contain the following columns:
  • Hash
  • Balance
  • % Of Circulating

but I see different columns:

  • Rank
  • Account
  • % Of Circulating

@janmichek
Copy link
Collaborator Author

janmichek commented Jan 2, 2024

According to Top Accounts Info: The top accounts are the accounts with the highest balance of AE coins. But I can see in the list that many accounts have 0 balance now and the last Tx was 10 months ago or 1-2 year ago. Is this correct order?

Good catch, was not checking it. I reported this to MDW aeternity/ae_mdw#1661 and putting this issue On Hold until resolved

@janmichek
Copy link
Collaborator Author

According to #616 description A new table should contain the following columns:

Balance added

Copy link
Collaborator

@Liubov-crypto Liubov-crypto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now it's better comparing to previous version. LGTM.

The last issue is remaining about accounts balances, waiting for mdw resolving.

@michele-franchi
Copy link
Collaborator

Closing this until the issue is not fixed on the mdw.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add top accounts page
3 participants