feat: use Mnesia module #506
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyeshe
force-pushed
the
396-use-database-module
branch
3 times, most recently
from
44039ab to
0be9515
Compare
jyeshe
force-pushed
the
396-use-database-module
branch
4 times, most recently
from
0fe7daf to
cf86791
Compare
jyeshe
force-pushed
the
396-use-database-module
branch
from
9ad272a to
606a5c5
Compare
jyeshe
force-pushed
the
396-use-database-module
branch
from
44059d8 to
0839879
Compare
thepiwo
approved these changes
Feb 9, 2022
sborrazas
approved these changes
Feb 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace use of
:mnesiawithAeMdw.Mnesiato generalize the database in a following PR.Functions that deal with transactions or reading context like
:mnesia.transaction,:mnesia.sync_transaction,:mnesia.sync_dirtywhere left to be replaced later as the signatures are different.Functions that deal with table management will be droped later as the Mdw will manage the tables/column families directly.
PS: As shown by 9f3f22b vs fba18f9, select is not a good candidate for this replacement (due to macros involved) and will be likely to be replaced directly by more straighforward approach like RocksDb iterator.