chore: precompute tx ids (#1239)

Author: jyeshe

lib/ae_mdw/application.ex

@@ -89,6 +89,11 @@ defmodule AeMdw.Application do
         {tx_field_types, put_in(tx_fields[type], fields), put_in(tx_ids[type], ids)}
       end)
 
+    tx_ids_values =
+      Enum.into(tx_ids, %{}, fn {type, field_ids} ->
+        {type, Map.values(field_ids)}
+      end)
+
     id_field_type_map =
       Enum.reduce(tx_ids, %{}, fn {type, ids_map}, acc ->
         for {field, pos} <- ids_map,
@@ -119,6 +124,7 @@ defmodule AeMdw.Application do
         tx_type: Util.inverse(type_name_map),
         tx_fields: tx_fields,
         tx_ids: tx_ids,
+        tx_ids_values: tx_ids_values,
         id_prefix: id_prefix_type_map,
         id_field_type: id_field_type_map |> Enum.concat([{[:_], nil}]),
         id_fields: [{[], MapSet.new(id_fields)}],

lib/ae_mdw/db/mutations/int_calls_mutation.ex

@@ -65,20 +65,20 @@ defmodule AeMdw.Db.IntCallsMutation do
         |> State.put(Model.FnameGrpIntContractCall, m_fname_grp_call)
 
       tx_type
-      |> Node.tx_ids()
-      |> Enum.reduce(state2, fn {_field, pos}, state ->
-        pk = Validate.id!(elem(tx, pos))
-        m_id_call = Model.id_int_contract_call(index: {pk, pos, call_txi, local_idx})
+      |> Node.tx_ids_values()
+      |> Enum.reduce(state2, fn field_pos, state ->
+        pk = Validate.id!(elem(tx, field_pos))
+        m_id_call = Model.id_int_contract_call(index: {pk, field_pos, call_txi, local_idx})
 
         m_grp_id_call =
-          Model.grp_id_int_contract_call(index: {create_txi, pk, pos, call_txi, local_idx})
+          Model.grp_id_int_contract_call(index: {create_txi, pk, field_pos, call_txi, local_idx})
 
         m_id_fname_call =
-          Model.id_fname_int_contract_call(index: {pk, fname, pos, call_txi, local_idx})
+          Model.id_fname_int_contract_call(index: {pk, fname, field_pos, call_txi, local_idx})
 
         m_grp_id_fname_call =
           Model.grp_id_fname_int_contract_call(
-            index: {create_txi, pk, fname, pos, call_txi, local_idx}
+            index: {create_txi, pk, fname, field_pos, call_txi, local_idx}
           )
 
         state

lib/ae_mdw/fields.ex

@@ -62,8 +62,8 @@ defmodule AeMdw.Fields do
     |> Enum.flat_map(fn tx_type ->
       types_pos =
         tx_type
-        |> Node.tx_ids()
-        |> Enum.map(fn {_field, pos} -> {tx_type, pos} end)
+        |> Node.tx_ids_values()
+        |> Enum.map(fn field_pos -> {tx_type, field_pos} end)
 
       if tx_type in @create_tx_types do
         [{tx_type, nil} | types_pos]

lib/ae_mdw/node.ex

@@ -195,6 +195,11 @@ defmodule AeMdw.Node do
     %{}
   end
 
+  @spec tx_ids_values(atom()) :: [non_neg_integer()]
+  def tx_ids_values(_tx_type) do
+    []
+  end
+
   @spec tx_mod(module()) :: module()
   def tx_mod(_arg) do
     :foo

lib/ae_mdw/txs.ex

@@ -374,7 +374,7 @@ defmodule AeMdw.Txs do
       end
 
     Enum.flat_map(tx_types, fn tx_type ->
-      poss = tx_type |> Node.tx_ids() |> Map.values() |> Enum.map(&{tx_type, &1})
+      poss = tx_type |> Node.tx_ids_values() |> Enum.map(&{tx_type, &1})
       # nil - for link
       poss = if tx_type in @create_tx_types, do: [{tx_type, nil} | poss], else: poss
 
@@ -544,9 +544,9 @@ defmodule AeMdw.Txs do
 
   defp field_count(state, tx_type, address) do
     tx_type
-    |> Node.tx_ids()
-    |> Enum.map(fn {_field, pos} ->
-      case State.get(state, Model.IdCount, {tx_type, pos, address}) do
+    |> Node.tx_ids_values()
+    |> Enum.map(fn field_pos ->
+      case State.get(state, Model.IdCount, {tx_type, field_pos, address}) do
         {:ok, Model.id_count(count: count)} -> count
         :not_found -> 0
       end

lib/ae_mdw_web/websocket/broadcaster.ex

@@ -264,10 +264,8 @@ defmodule AeMdwWeb.Websocket.Broadcaster do
     {tx_type, naked_tx} = :aetx.specialize_type(wrapped_tx)
 
     tx_type
-    |> AeMdw.Node.tx_ids()
-    |> Map.values()
+    |> AeMdw.Node.tx_ids_values()
     |> Enum.map(&elem(naked_tx, &1))
-    |> Enum.map(&AeMdw.Validate.id!/1)
     |> Enum.uniq()
   end