chore: sort DEX swaps by creation instead of contract creation (#1882)

Author: sborrazas

lib/ae_mdw/db/contract.ex

@@ -462,7 +462,7 @@ defmodule AeMdw.Db.Contract do
         )
         |> State.put(
           Model.DexSwapTokens,
-          Model.dex_swap_tokens(index: {create_txi, txi, idx})
+          Model.dex_swap_tokens(index: {txi, idx, create_txi})
         )
 
       false ->

lib/ae_mdw/db/model.ex

@@ -483,8 +483,8 @@ defmodule AeMdw.Db.Model do
   defrecord :dex_contract_swap_tokens, @dex_contract_swap_tokens_defaults
 
   # DEX swap tokens indexed by contract:
-  #     index: {create_txi, txi, log_idx}
-  @type dex_swap_tokens_index() :: {integer(), integer(), integer()}
+  #     index: {txi, log_idx, create_txi}
+  @type dex_swap_tokens_index() :: {txi(), log_idx(), txi()}
   @type dex_swap_tokens ::
           record(:dex_swap_tokens,
             index: dex_swap_tokens_index()

lib/ae_mdw/dex.ex

@@ -120,12 +120,13 @@ defmodule AeMdw.Dex do
       cursor =
         case cursor do
           nil -> nil
-          {_account_pk, create_txi, txi, log_idx} -> {create_txi, txi, log_idx}
+          {_account_pk, create_txi, txi, log_idx} -> {txi, log_idx, create_txi}
         end
 
       state
       |> Collection.stream(@swaps_table, direction, nil, cursor)
-      |> Stream.map(fn {create_txi, txi, log_idx} = index ->
+      |> Stream.map(fn {txi, log_idx, create_txi} ->
+        index = {create_txi, txi, log_idx}
         Model.contract_log(args: [from, _to]) = State.fetch!(state, Model.ContractLog, index)
 
         {from, create_txi, txi, log_idx}

priv/migrations/20240801120000_sort_general_dex_swaps_by_creation.ex

@@ -0,0 +1,43 @@
+defmodule AeMdw.Migrations.SortGeneralDexSwapsByCreation do
+  @moduledoc """
+  Reindex dex swaps by txi index of create_txi.
+  """
+
+  alias AeMdw.Collection
+  alias AeMdw.Db.Model
+  alias AeMdw.Db.State
+  alias AeMdw.Db.DeleteKeysMutation
+  alias AeMdw.Db.WriteMutation
+
+  require Model
+
+  @spec run(State.t(), boolean()) :: {:ok, non_neg_integer()}
+  def run(state, _from_start?) do
+    mutations_length =
+      state
+      |> Collection.stream(Model.DexSwapTokens, nil)
+      |> Enum.map(fn {create_txi, txi, idx} = key ->
+        {
+          WriteMutation.new(
+            Model.DexSwapTokens,
+            Model.dex_swap_tokens(index: {txi, idx, create_txi})
+          ),
+          key
+        }
+      end)
+      |> Stream.chunk_every(1000)
+      |> Stream.map(fn chunk ->
+        {mutations, deletion_keys} = Enum.unzip(chunk)
+
+        mutations = [
+          DeleteKeysMutation.new(%{Model.DexSwapTokens => deletion_keys}) | mutations
+        ]
+
+        _state = State.commit_db(state, mutations)
+        length(mutations)
+      end)
+      |> Enum.sum()
+
+    {:ok, mutations_length}
+  end
+end

test/ae_mdw_web/controllers/dex_controller_test.exs

@@ -90,7 +90,7 @@ defmodule AeMdwWeb.DexControllerTest do
             )
             |> Store.put(
               Model.DexSwapTokens,
-              Model.dex_swap_tokens(index: {pair_txi, txi, log_idx})
+              Model.dex_swap_tokens(index: {txi, log_idx, pair_txi})
             )
             |> Store.put(
               Model.ContractLog,
@@ -279,7 +279,7 @@ defmodule AeMdwWeb.DexControllerTest do
           # CASE 1
           |> Store.put(
             Model.DexSwapTokens,
-            Model.dex_swap_tokens(index: {pair_txi, txi1, log_idx})
+            Model.dex_swap_tokens(index: {txi1, log_idx, pair_txi})
           )
           |> Store.put(
             Model.DexAccountSwapTokens,
@@ -307,7 +307,7 @@ defmodule AeMdwWeb.DexControllerTest do
           # CASE 2
           |> Store.put(
             Model.DexSwapTokens,
-            Model.dex_swap_tokens(index: {pair_txi, txi2, log_idx})
+            Model.dex_swap_tokens(index: {txi2, log_idx, pair_txi})
           )
           |> Store.put(
             Model.ContractLog,
@@ -336,7 +336,7 @@ defmodule AeMdwWeb.DexControllerTest do
           # CASE 3
           |> Store.put(
             Model.DexSwapTokens,
-            Model.dex_swap_tokens(index: {pair_txi, txi3, log_idx})
+            Model.dex_swap_tokens(index: {txi3, log_idx, pair_txi})
           )
           |> Store.put(
             Model.ContractLog,
@@ -374,7 +374,7 @@ defmodule AeMdwWeb.DexControllerTest do
           # CASE 4
           |> Store.put(
             Model.DexSwapTokens,
-            Model.dex_swap_tokens(index: {pair_txi, txi4, log_idx})
+            Model.dex_swap_tokens(index: {txi4, log_idx, pair_txi})
           )
           |> Store.put(
             Model.ContractLog,