Skip to content

Commit 016e357

Browse files
committed
refactor: tests comparision of names with auction
1 parent deede55 commit 016e357

File tree

1 file changed

+8
-12
lines changed

1 file changed

+8
-12
lines changed

test/integration/ae_mdw_web/controllers/name_controller_test.exs

Lines changed: 8 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -144,9 +144,8 @@ defmodule Integration.AeMdwWeb.NameControllerTest do
144144
@default_limit
145145
)
146146

147-
data = add_name_ttl(data, "auction")
148147
assert Enum.count(response["data"]) <= @default_limit
149-
assert Jason.encode!(response["data"]) == Jason.encode!(data)
148+
assert Jason.encode!(response["data"]) == Jason.encode!(add_name_ttl(data, "auction"))
150149

151150
conn_next = get(conn, response["next"])
152151
response_next = json_response(conn_next, 200)
@@ -157,9 +156,10 @@ defmodule Integration.AeMdwWeb.NameControllerTest do
157156
@default_limit
158157
)
159158

160-
next_data = add_name_ttl(next_data, "auction")
161159
assert Enum.count(response_next["data"]) == @default_limit
162-
assert Jason.encode!(response_next["data"]) == Jason.encode!(next_data)
160+
161+
assert Jason.encode!(response_next["data"]) ==
162+
Jason.encode!(add_name_ttl(next_data, "auction"))
163163
end
164164

165165
test "get inactive names with limit=6", %{conn: conn} do
@@ -173,9 +173,8 @@ defmodule Integration.AeMdwWeb.NameControllerTest do
173173
limit
174174
)
175175

176-
data = add_name_ttl(data, "auction")
177176
assert Enum.count(response["data"]) <= limit
178-
assert Jason.encode!(response["data"]) == Jason.encode!(data)
177+
assert Jason.encode!(response["data"]) == Jason.encode!(add_name_ttl(data, "auction"))
179178
end
180179

181180
test "get inactive names with parameters by=name, direction=forward and limit=4", %{
@@ -273,9 +272,8 @@ defmodule Integration.AeMdwWeb.NameControllerTest do
273272
@default_limit
274273
)
275274

276-
data = add_name_ttl(data, "info")
277275
assert Enum.count(response["data"]) <= @default_limit
278-
assert Jason.encode!(response["data"]) == Jason.encode!(data)
276+
assert Jason.encode!(response["data"]) == Jason.encode!(add_name_ttl(data, "info"))
279277
end
280278

281279
test "get auctions with limit=2", %{conn: conn} do
@@ -289,9 +287,8 @@ defmodule Integration.AeMdwWeb.NameControllerTest do
289287
limit
290288
)
291289

292-
data = add_name_ttl(data, "info")
293290
assert Enum.count(response["data"]) <= limit
294-
assert Jason.encode!(response["data"]) == Jason.encode!(data)
291+
assert Jason.encode!(response["data"]) == Jason.encode!(add_name_ttl(data, "info"))
295292
end
296293

297294
test "get auctions with parameters by=expiration, direction=forward and limit=3", %{
@@ -310,9 +307,8 @@ defmodule Integration.AeMdwWeb.NameControllerTest do
310307
limit
311308
)
312309

313-
data = add_name_ttl(data, "info")
314310
assert Enum.count(response["data"]) <= limit
315-
assert Jason.encode!(response["data"]) == Jason.encode!(data)
311+
assert Jason.encode!(response["data"]) == Jason.encode!(add_name_ttl(data, "info"))
316312
end
317313

318314
test "renders error when parameter by is invalid", %{conn: conn} do

0 commit comments

Comments
 (0)