Adapt new behavior of System.console() since JDK22 #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsmet
reviewed
Mar 30, 2024
| // Console.isTerminal() was introduced in Java 22 | ||
| private static boolean isTerminal(Console console) { | ||
| try { | ||
| Method isTerminal = Console.class.getMethod("isTerminal"); |
There was a problem hiding this comment.
Not sure if it's worth switching to a multi-versioned jar instead of relying on reflection + exception?
There was a problem hiding this comment.
Hm, instead of reflection could we check if Runtime.version() > 21 ?
Tbh, I'm not sure what's the "best" solution here, I'm open for anything. This method is usually not called more than once anyway...
There was a problem hiding this comment.
Then the new method isTerminal won't compile on older JDKs (<= 21).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #68