Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced mu variables by mu_Earth and mu_Sun variables #255

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Arunim10
Copy link

After seeing all the python codes in this orbit determinator, I thought that initialising a variable mu for storing gravitational parameter of Earth and sun , was a creating much confusion. So I replaced all the variables mu ,in which the gravitational parameters of Earth and sun was stored, by mu_Earth and mu_Sun respectively.

First Commit : "replace mu by mu_Earth"

You can see in the changed files that I have changed all the variables mu by mu_Earth and mu_Sun wherever required and by doing this , I have avoided the confusion of having mu in many places.
I have also kept the units of mu_Earth and mu_Sun uniform throughout the whole orbitdeterminator program i.e.. , km^3/sec^2 for mu_Earth and au^3/day^2 . This avoided the problem of changing the units of these value in many places.
For instance,
In this python file orbitdeterminator/kep_determination/least_squares.py, previously in line 463, mu_Earth was assigned its value in m^3/sec^2 units but I changed it into units of km^3/sec^2 to maintain uniformity and then wherever mu_Earth was needed in terms of m^3/sec^2 units , I simply multiplied mu_Earth(km^3/sec^2) with 10**(9) to convert it into m^3/sec^2 units.

Second Commit : "Replace mu variable by mu_Earth variable"

I had written some rough code so as to check that whether the code was running fine , so in this commit , I have commented those codes.

@Arunim10 Arunim10 closed this Jan 12, 2022
@Arunim10 Arunim10 reopened this Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant