Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: minor updates to arrays #184

Merged
merged 3 commits into from
May 20, 2024
Merged

Conversation

toumorokoshi
Copy link
Member

  • lowered guidance to should (since it is not critical for an auto-generated client)

馃嵄 Types of changes

What types of changes does your code introduce to AEP? Put an x in the boxes
that apply

  • Enhancement
  • New proposal
  • Migrated from google.aip.dev
  • Chore / Quick Fix

馃搵 Your checklist for this pull request

Please review the AEP Style and Guidance for
contributing to this repository.

General

Additional checklist for a new AEP

  • A new AEP should be no more than two pages if printed out.
  • Ensure that the PR is editable by maintainers.
  • Ensure that File structure
    guidelines are met.
  • Ensure that
    Document structure
    guidelines are met.

馃挐 Thank you!

- lowered guidance to should (since it is not critical for an
  auto-generated client)
@toumorokoshi
Copy link
Member Author

I started taking a stab at this, but before I get deeper - I'm having mixed feels about the existing guidance around allowing single-element add/delete custom methods: https://aep.dev/144#update-strategies.

I feel like we could do better - probably just relying on json patch: https://jsonpatch.com/

Copy link
Contributor

@mkistler mkistler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. 馃憤

Left one little suggestion.

aep/general/0144/aep.md.j2 Show resolved Hide resolved
aep/general/0144/aep.md.j2 Outdated Show resolved Hide resolved
aep/general/0144/aep.md.j2 Show resolved Hide resolved
aep/general/0144/aep.md.j2 Outdated Show resolved Hide resolved
@toumorokoshi toumorokoshi marked this pull request as ready for review May 16, 2024 05:35
@toumorokoshi toumorokoshi requested a review from a team as a code owner May 16, 2024 05:35
@toumorokoshi toumorokoshi merged commit 86c5e9d into aep-dev:main May 20, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants