Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reading across collections #164

Merged
merged 4 commits into from
Jun 7, 2024

Conversation

rofrankel
Copy link
Collaborator

📑 Proposed changes

Adopt AIP-159: Reading across collections

🍱 Types of changes

What types of changes does your code introduce to AEP? Put an x in the boxes
that apply

📋 Your checklist for this pull request

Please review the AEP Style and Guidance for
contributing to this repository.

General

Additional checklist for a new AEP

  • A new AEP should be no more than two pages if printed out.
  • Ensure that the PR is editable by maintainers.
  • Ensure that File structure
    guidelines are met.
  • Ensure that
    Document structure
    guidelines are met.

💝 Thank you!

@rofrankel rofrankel requested a review from a team as a code owner April 10, 2024 20:53
@toumorokoshi toumorokoshi self-requested a review April 12, 2024 19:21
Copy link
Member

@toumorokoshi toumorokoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

first review done! some conversation starters.

aep/general/0159/aep.md.j2 Show resolved Hide resolved
aep/general/0159/aep.md.j2 Show resolved Hide resolved
aep/general/0159/aep.md.j2 Show resolved Hide resolved
aep/general/0159/aep.md.j2 Show resolved Hide resolved
aep/general/0159/aep.md.j2 Outdated Show resolved Hide resolved
aep/general/0159/aep.md.j2 Show resolved Hide resolved
aep/general/0159/aep.md.j2 Show resolved Hide resolved
aep/general/0159/aep.md.j2 Show resolved Hide resolved
@rofrankel rofrankel linked an issue May 7, 2024 that may be closed by this pull request
Copy link
Contributor

@mkistler mkistler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. 👍

@rofrankel rofrankel merged commit 9bc1429 into aep-dev:main Jun 7, 2024
2 checks passed
@rofrankel rofrankel deleted the reading-across-collections branch June 7, 2024 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adopt AIP-0159 Reading across collections
5 participants