build-windows: include 5 needed DLLs in the package #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stoffu
changed the title
…ssp-0,libiconv-2,libgcc_s_seh-1) in the package
stoffu
force-pushed
the
aeon-ci-workaround
branch
from
36b0007
to
f6fae9d
Compare
|
Why is the macOS CI failing? |
|
It's getting a segmentation fault when finishing the IBD test mode. It used to work fine previously, and I have no idea why. Should this be fixed before releasing? |
stoffu
changed the title
|
Maybe try to assess why it is happening then decide? |
stoffu
force-pushed
the
aeon-ci-workaround
branch
from
1646f76
to
f6fae9d
Compare
|
While I was investigating, the error disappeared somehow without me making any changes to the code. Very weird, but I guess that’s how it is with GitHub CI. |
stoffu
changed the title
|
So are unit tests the only update for .2? |
|
@BigslimVdub The important update is including the DLLs so the windows build will actually work. The unit tests failed for some unknown reason and then started working again for some unknown reason. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.