Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Type hints for primitives and string arguments:Part3 #1525

Merged
merged 3 commits into from
May 25, 2024

Conversation

nileenagp
Copy link
Contributor

Reference Issues/PRs
Part of #1454

What does this implement/fix? Explain your changes.
Adding type hints to remaining scripts in : aeon/classification/sklearn/_continuous_interval_tree.py ( Existing class _TreeNode, has been moved above ContinuousIntervalTree, in order to include the type[_TreeNode] in the type hints)

aeon/classification/shapelet_based scripts.

Does your contribution introduce a new dependency? If yes, which one?
None

Any other comments?
Type hints are NOT added in other methods since they were not primitive types.

@aeon-actions-bot aeon-actions-bot bot added classification Classification package enhancement New feature, improvement request or other non-bug code enhancement labels May 13, 2024
@aeon-actions-bot
Copy link
Contributor

Thank you for contributing to aeon

I have added the following labels to this PR based on the title: [ $\color{#FEF1BE}{\textsf{enhancement}}$ ].
I have added the following labels to this PR based on the changes made: [ $\color{#BCAE15}{\textsf{classification}}$ ]. Feel free to change these if they do not properly represent the PR.

The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.

If our pre-commit code quality check fails, any trivial fixes will automatically be pushed to your PR unless it is a draft.

Don't hesitate to ask questions on the aeon Slack channel if you have any.

Copy link
Contributor

@baraline baraline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for the contribution !

@baraline baraline merged commit 24bc889 into aeon-toolkit:main May 25, 2024
14 checks passed
@nileenagp nileenagp deleted the aeon_work branch May 28, 2024 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
classification Classification package enhancement New feature, improvement request or other non-bug code enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants