Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] remove none argument for coerce to period #1514

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

TonyBagnall
Copy link
Contributor

fixes #1346

this just removes the option for freq=None for the private function _coerce_to_period which is never called without a freq argument, see #1346 for reasons

@TonyBagnall TonyBagnall added the forecasting Forecasting package label May 11, 2024
@aeon-actions-bot aeon-actions-bot bot added the bug Something isn't working label May 11, 2024
@aeon-actions-bot
Copy link
Contributor

Thank you for contributing to aeon

I have added the following labels to this PR based on the title: [ $\color{#d73a4a}{\textsf{bug}}$ ].
I would have added the following labels to this PR based on the changes made: [ $\color{#31FCCD}{\textsf{forecasting}}$ ], however some package labels are already present.

The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.

If our pre-commit code quality check fails, any trivial fixes will automatically be pushed to your PR unless it is a draft.

Don't hesitate to ask questions on the aeon Slack channel if you have any.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working forecasting Forecasting package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] _coerce_to_period fails when not passed a freq argument
1 participant