Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] mpdist window length #1513

Merged
merged 5 commits into from
May 14, 2024
Merged

[BUG] mpdist window length #1513

merged 5 commits into from
May 14, 2024

Conversation

TonyBagnall
Copy link
Contributor

fixes #1498

the window length (called m for some reason) has as default value of 0, which means its set to a quarter of the length of the series. However, this check was happening after forming the windows, so it was trying to form windows with 0 length.

I think it might be better to just use stumpy for this, m = None should be the default and k/threshold should definitely be a parameter. I will see if it makes a difference in a separate PR

@TonyBagnall TonyBagnall added the distances Distances package label May 11, 2024
@aeon-actions-bot aeon-actions-bot bot added the bug Something isn't working label May 11, 2024
@aeon-actions-bot
Copy link
Contributor

Thank you for contributing to aeon

I have added the following labels to this PR based on the title: [ $\color{#d73a4a}{\textsf{bug}}$ ].
I would have added the following labels to this PR based on the changes made: [ $\color{#5209C9}{\textsf{distances}}$ ], however some package labels are already present.

The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.

If our pre-commit code quality check fails, any trivial fixes will automatically be pushed to your PR unless it is a draft.

Don't hesitate to ask questions on the aeon Slack channel if you have any.

@MatthewMiddlehurst MatthewMiddlehurst added the codecov actions Run the codecov action on a PR label May 12, 2024
@MatthewMiddlehurst
Copy link
Member

could you make a change to run the CI again? If there are other problems would be good to create an issue.

aeon/distances/_mpdist.py Outdated Show resolved Hide resolved
aeon/distances/_mpdist.py Outdated Show resolved Hide resolved
@baraline
Copy link
Contributor

baraline commented May 13, 2024

Overall I agree that having m=0 just feels weird as default value, None would be better !
Using stumpy would also make sense as we have it as softdep already.

At some point the same functionality should be available with similairty search if you want something "in house". Advantage would be that you could choose the internal distance to use (ED, DTW, etc...)

@TonyBagnall TonyBagnall requested a review from baraline May 13, 2024 18:31
Copy link
Contributor

@baraline baraline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM to me now !

@TonyBagnall TonyBagnall merged commit 224ad9e into main May 14, 2024
17 checks passed
@TonyBagnall TonyBagnall deleted the ajb/mp_dist branch May 14, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working codecov actions Run the codecov action on a PR distances Distances package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] matrix profile distance index out of bounds test failure
3 participants