Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEP] Deprecate simple wrapper transformers #1494

Merged
merged 8 commits into from
May 20, 2024
Merged

[DEP] Deprecate simple wrapper transformers #1494

merged 8 commits into from
May 20, 2024

Conversation

TonyBagnall
Copy link
Contributor

@TonyBagnall TonyBagnall commented May 5, 2024

deprecate transformers we dont want to keep

Removes

  • TimeBinning: not used anywhere, not covered by tests
  • IndexSubset and ColumnSelect: simple operations
  • CosineTransformer: one line scikit wrapper
  • SqrtTransformer: one line numpy wrapper
  • Augmenters: adds noise to series, not really needed

part of #1446

@TonyBagnall TonyBagnall added transformations Transformations package deprecation This issue is related to deprecation or removal of code labels May 5, 2024
@aeon-actions-bot
Copy link
Contributor

Thank you for contributing to aeon

I would have added the following labels to this PR based on the changes made: [ $\color{#41A8F6}{\textsf{transformations}}$ ], however some package labels are already present.

The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.

If our pre-commit code quality check fails, any trivial fixes will automatically be pushed to your PR unless it is a draft.

Don't hesitate to ask questions on the aeon Slack channel if you have any.

@TonyBagnall TonyBagnall changed the title [DEP] deprecate cos and sqrt transformers [DEP] Remove unnecessary transformers May 5, 2024
@TonyBagnall TonyBagnall changed the title [DEP] Remove unnecessary transformers [DEP] Deprecate simple wrapper transformers May 5, 2024
@TonyBagnall TonyBagnall marked this pull request as ready for review May 6, 2024 15:39
@TonyBagnall TonyBagnall requested a review from aiwalter as a code owner May 6, 2024 15:39
Copy link
Member

@MatthewMiddlehurst MatthewMiddlehurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think they have to be used in the package for them to be useful to have. Some of these seem like they could be useful. Still, happy to deprecate them given they are the old format and can be moved over later.

@TonyBagnall TonyBagnall merged commit 5f4b8b1 into main May 20, 2024
15 checks passed
@TonyBagnall TonyBagnall deleted the ajb/remove branch May 20, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deprecation This issue is related to deprecation or removal of code transformations Transformations package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants