Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNT] Changes to no soft dependency tests #1476

Merged
merged 6 commits into from
May 17, 2024

Conversation

MatthewMiddlehurst
Copy link
Member

@MatthewMiddlehurst MatthewMiddlehurst commented Apr 26, 2024

What does this implement/fix? Explain your changes.

Merged the two soft dependency workflow jobs into a single one which runs all tests on the periodic workflow and all tests but the "TestAllEstimator" tests on PRs.

Slims down the module soft dependency check. This did not actually work previously as the module variable was an empty list. Previously the test would check for "soft dependency modules" which rely on soft dependencies, the new test removes this concept. Everything must be isolated with no exceptions (yet) in the new version. Skips modules containing "tests" in the path on PRs.

@aeon-actions-bot aeon-actions-bot bot added the maintenance Continuous integration, unit testing & package distribution label Apr 26, 2024
@aeon-actions-bot
Copy link
Contributor

Thank you for contributing to aeon

I have added the following labels to this PR based on the title: [ $\color{#EC843A}{\textsf{maintenance}}$ ].

The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.

If our pre-commit code quality check fails, any trivial fixes will automatically be pushed to your PR unless it is a draft.

Don't hesitate to ask questions on the aeon Slack channel if you have any.

@MatthewMiddlehurst MatthewMiddlehurst added the testing Testing related issue or pull request label Apr 27, 2024
@MatthewMiddlehurst MatthewMiddlehurst marked this pull request as ready for review April 27, 2024 14:50
Copy link
Contributor

@TonyBagnall TonyBagnall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine to me, maybe @chrisholder could take a look?

@MatthewMiddlehurst MatthewMiddlehurst merged commit a997a64 into main May 17, 2024
14 checks passed
@MatthewMiddlehurst MatthewMiddlehurst deleted the mm/no-soft-dep-tests branch May 17, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Continuous integration, unit testing & package distribution testing Testing related issue or pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants