Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Update VARMAX pandas 2.0 #1416

Closed

Conversation

AnonymousCodes911
Copy link
Contributor

updated pandas version to 2.0

Reference Issues/PRs

#291

updated pandas version to 2.0
@aeon-actions-bot aeon-actions-bot bot added enhancement New feature, improvement request or other non-bug code enhancement forecasting Forecasting package labels Apr 11, 2024
@aeon-actions-bot
Copy link
Contributor

Thank you for contributing to aeon

I have added the following labels to this PR based on the title: [ $\color{#FEF1BE}{\textsf{enhancement}}$ ].
I have added the following labels to this PR based on the changes made: [ $\color{#31FCCD}{\textsf{forecasting}}$ ]. Feel free to change these if they do not properly represent the PR.

The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.

If our pre-commit code quality check fails, any trivial fixes will automatically be pushed to your PR unless it is a draft.

Don't hesitate to ask questions on the aeon Slack channel if you have any.

@AnonymousCodes911 AnonymousCodes911 marked this pull request as draft April 11, 2024 17:52
@AnonymousCodes911
Copy link
Contributor Author

AnonymousCodes911 commented Apr 11, 2024

@MatthewMiddlehurst, is this change a fix?, or should we deprecate certain functions to ensure compatibility? local Tests are currently being skipped due to the absence of soft dependencies.

@MatthewMiddlehurst
Copy link
Member

No, this is not the fix required. You will see issues emerge if you remove the dependency line completely.

@AnonymousCodes911
Copy link
Contributor Author

@MatthewMiddlehurst , Thanks! I will work accordingly.

-modified the tests to check for pandas>2.0.0.
-removed unused import
@MatthewMiddlehurst MatthewMiddlehurst added the full pytest actions Run the full pytest suite on a PR label Apr 15, 2024
@MatthewMiddlehurst
Copy link
Member

I think it's best to leave this for now, IMO. We have some significant changes to the module planned which may make this irrelevant either way.

@AnonymousCodes911
Copy link
Contributor Author

I see, I ll Close this for now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature, improvement request or other non-bug code enhancement forecasting Forecasting package full pytest actions Run the full pytest suite on a PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants