OpenZeppelin Contracts TransparentUpgradeableProxy clashing selector calls may not be delegated
Moderate severity
GitHub Reviewed
Published
Apr 13, 2023
in
OpenZeppelin/openzeppelin-contracts
•
Updated Nov 23, 2023
Description
Published to the GitHub Advisory Database
Apr 17, 2023
Reviewed
Apr 17, 2023
Published by the National Vulnerability Database
Apr 17, 2023
Last updated
Nov 23, 2023
Credits
-
MarkLee131 Analyst
Impact
A function in the implementation contract may be inaccessible if its selector clashes with one of the proxy's own selectors. Specifically, if the clashing function has a different signature with incompatible ABI encoding, the proxy could revert while attempting to decode the arguments from calldata.
The probability of an accidental clash is negligible, but one could be caused deliberately.
Patches
The issue has been fixed in v4.8.3.
Workarounds
If a function appears to be inaccessible for this reason, it may be possible to craft the calldata such that ABI decoding does not fail at the proxy and the function is properly proxied through.
References
OpenZeppelin/openzeppelin-contracts#4154
References