Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better handling on persistent connexion #8

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Better handling on persistent connexion #8

wants to merge 2 commits into from

Conversation

ogarbe
Copy link

@ogarbe ogarbe commented Apr 27, 2015

  • close socket
  • close socket on destructor
  • public function close
  • formatted response (header / body ...)

@Timandes
Copy link
Contributor

I also think splitting the response is a good idea, but it's probably not compatible with existing codes.
I suggest we could provide a parameter, or at least a switch to make things more flexible.

@ogarbe
Copy link
Author

ogarbe commented Apr 28, 2015

i've added it

@Timandes
Copy link
Contributor

Amazing efficiency!

@ogarbe ogarbe mentioned this pull request Apr 28, 2015
Merged
@ogarbe
Copy link
Author

ogarbe commented May 13, 2015

@adoy : hello, what do you think about this ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ogarbe @Timandes