Improvements of command line tool #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separate Unix domain socket filepath and script filepath into two command line arguments. This is absolutely needed because the regular expression used before is not able to separate socket path and URL path correctly.
Steps to reproduce:
Try the following argument value
unix:/var/run/php-fpm/web.sock.1/path.sock/?query=.sock/#segment=.sock/Actual result:
https://regex101.com/r/gG7jO2/3
Socket path: (1st capture group):
unix:/var/run/php-fpm/web.sock.1/path.sock/?query=.sock/#segment=.sockURL path (2nd capture group):
/Expected result:
Socket path:
unix:/var/run/php-fpm/web.sock.1URL path:
/path.sock/?query=.sock/#segment=.sock/Show full script path in log and send full script path in SCRIPT_NAME, REQUEST_URI and DOCUMENT_URI.