-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix docker hub link creation for releases #1007
base: main
Are you sure you want to change the base?
Conversation
Quality Gate passedIssues Measures |
Hi @BreakBB, could you please rebase your PRs onto the current main so we can see whether the Github Actions work now? Best Regards |
Hi @BreakBB, I managed to merge the current main into your branch and pushed it. The CI-change you did is still invalid: https://github.com/adorsys/keycloak-config-cli/actions/runs/9399408127
Best Regards |
Signed-off-by: Jonas Voelcker <barmer@jonas-voelcker.de>
Signed-off-by: Jonas Voelcker <barmer@jonas-voelcker.de>
Quality Gate passedIssues Measures |
Hi @francis-pouatcha, |
Thanks for actually fixing the issue @jonasvoelcker At a second glance |
What this PR does / why we need it:
Currently the link generated for the release body has the following format:
However the docker images omit the
v
-prefix, so these links don't provide any results.Special notes for your reviewer:
PR Readiness Checklist:
Complete these before marking the PR as
ready to review
:CHANGELOG.md
release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR