Generate VDR Using Github Actions #15
Conversation
Scanteianu
changed the title
.github/workflows/vdr-creation.yml
Outdated
| - name: Install dependencies | ||
| run: | | ||
| python -m pip install --upgrade pip | ||
| pip install flake8 pytest |
There was a problem hiding this comment.
So we need flake8 and pytest in this workflow?
There was a problem hiding this comment.
i'd rather fail it early instead of running the vdr creation on a failing PR but i'm open to suggestions
There was a problem hiding this comment.
You already have a CI workflow though so why duplicate?
There was a problem hiding this comment.
i can remove it; is there any way for the CI action to kill this one upon failure?
Co-authored-by: George Adams <georgeadams1995@gmail.com>
.github/workflows/vdr-creation.yml
Outdated
| workflow_dispatch: | ||
| push: | ||
| branches: [ main ] | ||
| pull_request: # todo: do we want it to run on all PRs? |
There was a problem hiding this comment.
You won't be able to use secrets in PR runs so it probably makes sense to remove this
There was a problem hiding this comment.
we can run in slow mode without the secrets (and there's a chance of some other PR or other github action elsewhere causing some throttling, although i've not seen this in trial runs), but getting the vdr result of a PR before merging I think is super valuable. Without the secret, the rate limit is 5 requests/30 seconds (with the secret it's 50). Experimentally, it takes <30 minutes to get the vdr generated without the secret, so I think it's worth waiting 30 mins and spot checking the vdr before actually merging a PR. In the future, we might integrate the GH actions cache to further speed up the CI.
Run pipeline to generate the VDR from Github Actions.
Publishes both the vdr and also the data directory with supporting artifacts.
Resolves #7