Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly obtain ALSA version for SBOM #3809

Merged
merged 1 commit into from
May 14, 2024

Conversation

andrew-m-leonard
Copy link
Contributor

Fixes #3807 issue(2.)

Correctly obtain the ALSA version from the built spec.gmk

Signed-off-by: Andrew Leonard <anleonar@redhat.com>
@andrew-m-leonard andrew-m-leonard self-assigned this May 14, 2024
@andrew-m-leonard andrew-m-leonard requested a review from sxa May 14, 2024 14:46
Copy link
Contributor

@steelhead31 steelhead31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@judovana
Copy link
Contributor

How does this behave with alsa download enabled?

@andrew-m-leonard
Copy link
Contributor Author

How does this behave with alsa download enabled?

It retreives the built libsoundj path to the alsa used, which for download will be the path in --with-alsa=...

@andrew-m-leonard andrew-m-leonard merged commit ada87f8 into adoptium:master May 14, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need to check version of ALSA being used for jdk21+ DevKit Linux builds?
4 participants