Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update code freeze bot to check target PR branch correctly for issue_comment #3770

Closed
wants to merge 18 commits into from

Conversation

andrew-m-leonard
Copy link
Contributor

@andrew-m-leonard andrew-m-leonard commented Apr 24, 2024

Code freeze is still incorrectly enabled on "master" branches.
This is because "issue_comment" event has no direct ability for branch filtering, it is a generic event.

To enable issue_comment filtering, we need to get the PR head ref branch, and perform a check
before using code-freeze.yml.

…comment

Signed-off-by: Andrew Leonard <anleonar@redhat.com>
@github-actions github-actions bot added the documentation Issues that request updates to our documentation label Apr 24, 2024
…comment

Signed-off-by: Andrew Leonard <anleonar@redhat.com>
@andrew-m-leonard
Copy link
Contributor Author

comment

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A block has been put on this Pull Request as this repository is temporarily under a code freeze due to an ongoing release cycle.

If this pull request needs to be merged during the release cycle then please comment /merge and a PMC member will be able to remove the block.

If the code freeze is over you can remove this block by commenting /thaw.

@andrew-m-leonard andrew-m-leonard marked this pull request as draft April 24, 2024 11:39
@andrew-m-leonard
Copy link
Contributor Author

/thaw

@github-actions github-actions bot dismissed their stale review April 25, 2024 08:28

Pull Request unblocked - code freeze is over.

…comment

Signed-off-by: Andrew Leonard <anleonar@redhat.com>
…comment

Signed-off-by: Andrew Leonard <anleonar@redhat.com>
…comment

Signed-off-by: Andrew Leonard <anleonar@redhat.com>
…comment

Signed-off-by: Andrew Leonard <anleonar@redhat.com>
…comment

Signed-off-by: Andrew Leonard <anleonar@redhat.com>
…comment

Signed-off-by: Andrew Leonard <anleonar@redhat.com>
…comment

Signed-off-by: Andrew Leonard <anleonar@redhat.com>
…comment

Signed-off-by: Andrew Leonard <anleonar@redhat.com>
…comment

Signed-off-by: Andrew Leonard <anleonar@redhat.com>
…comment

Signed-off-by: Andrew Leonard <anleonar@redhat.com>
…comment

Signed-off-by: Andrew Leonard <anleonar@redhat.com>
@andrew-m-leonard
Copy link
Contributor Author

test

…comment

Signed-off-by: Andrew Leonard <anleonar@redhat.com>
@andrew-m-leonard
Copy link
Contributor Author

test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Issues that request updates to our documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant