making local alsa properly optional #3756
Conversation
|
I admit I had made an fundamental build change, but Still I was not expecting build failures. In addition, they do not look related.... /me confused ..even windows... edit: Those are future jdk-head only, and do not seem indeed related (but second eye would be awesome!) |
|
ping please? |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
A block has been put on this Pull Request as this repository is temporarily under a code freeze due to an ongoing release cycle.
If this pull request needs to be merged during the release cycle then please comment /merge and a PMC member will be able to remove the block.
If the code freeze is over you can remove this block by commenting /thaw.
Co-authored-by: Martijn Verburg <martijnverburg@gmail.com>
Co-authored-by: Martijn Verburg <martijnverburg@gmail.com>
|
tyvm! |
|
@andrew-m-leonard @sxa Thoughts? |
|
/thaw |
github-actions
bot
dismissed
their stale review
Pull Request unblocked - code freeze is over.
|
tyvm! /integrate |
This pr is dong two things (afaik so connected that should be together)
The second commit + my old #3737 should be enough for offline build.
related to #3752