New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove 's' from sleep commands as unecessary and not universal #3748
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Stewart X Addison <sxa@redhat.com>
You were faster :) I was just on it.
So afaik all.. the mac build is irrelevant. |
if #3744 will go first, please use that :) |
@sxa neeeds rebase or close |
Close is dependent on the other pr being approved and merged. The rebase is not required now but is suggested as part of a recent undocumented change to the workflows ... |
3744 was merged.. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@sxa needs a rebase |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A block has been put on this Pull Request as this repository is temporarily under a code freeze due to an ongoing release cycle.
If this pull request needs to be merged during the release cycle then please comment /merge
and a PMC member will be able to remove the block.
If the code freeze is over you can remove this block by commenting /thaw
.
Syntax in a few places is invalid for Solaris:
Identified as part of #3744