Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 's' from sleep commands as unecessary and not universal #3748

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sxa
Copy link
Member

@sxa sxa commented Apr 4, 2024

Syntax in a few places is invalid for Solaris:

-bash-3.2$ sleep 5s
sleep: bad character in argument
-bash-3.2$ 

Identified as part of #3744

Signed-off-by: Stewart X Addison <sxa@redhat.com>
@sxa sxa self-assigned this Apr 4, 2024
@github-actions github-actions bot added the jenkins Issues that enhance or fix our jenkins server label Apr 4, 2024
@judovana
Copy link
Contributor

judovana commented Apr 4, 2024

You were faster :) I was just on it.

grep -ir "[ ^]sleep.*s"
build-farm/make-adopt-build-farm.sh:            sleep 30s
sbin/prepareWorkspace.sh:        sleep 10s
sbin/common/common.sh:            sleep 30s

So afaik all.. the mac build is irrelevant.

@judovana
Copy link
Contributor

judovana commented Apr 4, 2024

if #3744 will go first, please use that :)

@judovana
Copy link
Contributor

judovana commented Apr 5, 2024

if #3744 will go first, please use that :)

Feel free to use #3744 O:)

@karianna
Copy link
Contributor

karianna commented Apr 5, 2024

@sxa neeeds rebase or close

@sxa
Copy link
Member Author

sxa commented Apr 6, 2024

Close is dependent on the other pr being approved and merged. The rebase is not required now but is suggested as part of a recent undocumented change to the workflows ...

@karianna
Copy link
Contributor

karianna commented Apr 6, 2024

3744 was merged..

Copy link
Contributor

@andrew-m-leonard andrew-m-leonard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@karianna
Copy link
Contributor

@sxa needs a rebase

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A block has been put on this Pull Request as this repository is temporarily under a code freeze due to an ongoing release cycle.

If this pull request needs to be merged during the release cycle then please comment /merge and a PMC member will be able to remove the block.

If the code freeze is over you can remove this block by commenting /thaw.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jenkins Issues that enhance or fix our jenkins server
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants