Use full xcode for MacOS/aarch64 JDK11 #2885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stewart X Addison <sxa@redhat.com>
github-actions
bot
added
macos
|
@andrew-m-leonard Can you approve this one too? Up to you whether you want to check it on your system first, but it's a prereq for getting JDK11/mac/aarch64 builds into the pipelines |
|
Merging - will look at getting the pipeline change in to build this too now ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It probably makes sense to use full Xcode for JDK11 on both MacOS architectures, but I was definitely getting build failures when using just the command line tools on aarch64.
Will likely be superceded by the changes in #2876 at some point.
Signed-off-by: Stewart X Addison sxa@redhat.com