Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

downloaded alsa is not used,local files are used via ./makejdk-any-platform.sh #3752

Open
judovana opened this issue Apr 6, 2024 · 5 comments
Labels
documentation Issues that request updates to our documentation

Comments

@judovana
Copy link
Contributor

judovana commented Apr 6, 2024

alsa - can the download of alsa be omitted and pointed to lcoal files via the ./makejdk-any-platform.sh ? If so, it is missing in man.

@judovana judovana added the documentation Issues that request updates to our documentation label Apr 6, 2024
@judovana
Copy link
Contributor Author

judovana commented Apr 8, 2024

ok. I t was investiageted that alsa indeed cna not be currenlty set on cmdline. Will draft a pr.
Pleae anyubody remove documentation label...

@judovana
Copy link
Contributor Author

judovana commented Apr 8, 2024

quotation from senior development:

 I would suggest adding a --user-alsa-installation <dir> and either ensure it gets copied to
${BUILD_CONFIG[WORKSPACE_DIR]}/${BUILD_CONFIG[WORKING_DIR]}/installedalsa
around abouts here: https://github.com/adoptium/temurin-build/blob/d889cc1223d106cc3a43e1fe9fa76a9559bfc10d/sbin/prepareWorkspace.sh#L655
or create a new BUILD_CONFIG[ALSA_LOCATION] which defaults to
${BUILD_CONFIG[WORKSPACE_DIR]}/${BUILD_CONFIG[WORKING_DIR]}/installedalsa
and can be overridden by --user-alsa-installation <dir> (edited) 

@judovana
Copy link
Contributor Author

judovana commented Apr 8, 2024

how is the build/installedalsa/ used? --with-alsa-include nor --with-alsa-lib is shown in the configure

I'm inclining more to -A (as is -F) to simply skip alsa downloading and then provide -with-alsa-include and --with-alsa-lib through -C, --configure-args wdyt?

@judovana
Copy link
Contributor Author

judovana commented Apr 8, 2024

The

addConfigureArg "--with-alsa=" "${BUILD_CONFIG[WORKSPACE_DIR]}/${BUILD_CONFIG[WORKING_DIR]}/installedalsa"
seems to be jdk8u only

@judovana
Copy link
Contributor Author

judovana commented Apr 8, 2024

checking for alsa/asoundlib.h... no
configure: error: Could not find alsa!
configure exiting with result code 1

withou alsa-devel uninstalled, the configure fails, and dwnloded alsa is not used

@judovana judovana changed the title can the download of alsa be omitted and pointed to lcoal files via the ./makejdk-any-platform.sh downloaded alsa is not used local files are used via ./makejdk-any-platform.sh Apr 8, 2024
@judovana judovana changed the title downloaded alsa is not used local files are used via ./makejdk-any-platform.sh downloaded alsa is not used,local files are used via ./makejdk-any-platform.sh Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Issues that request updates to our documentation
Projects
None yet
Development

No branches or pull requests

1 participant