Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update clean workspace param #43

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

fix: update clean workspace param #43

wants to merge 1 commit into from

Conversation

sakshi1215
Copy link

@sakshi1215 sakshi1215 commented Oct 13, 2022 •
edited by zdtsw

@sakshi1215
Copy link
Author

@zdtsw @karianna Can you please review this?

@sakshi1215 sakshi1215 mentioned this pull request Oct 13, 2022
Draft
@sakshi1215
Copy link
Author

Can we merge this @karianna & @zdtsw ?

@zdtsw
Copy link
Contributor

zdtsw commented Oct 14, 2022

We could have this one merged but any ongoing build will fail immediately with so many calls to the helper.
Then to have adoptium/ci-jenkins-pipelines#440 merged in, which requires re-run all pipelines to get a clean view of how quality is before CPU.
I leave the decision to others either to merge both PRs before I can declare code freeze or put it on "post-release"

@karianna karianna marked this pull request as draft October 14, 2022 09:33
@karianna
Copy link
Contributor

Let's put this in draft and merge post release week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karianna karianna karianna approved these changes

@andrew-m-leonard andrew-m-leonard Awaiting requested review from andrew-m-leonard

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
waiting-merge-post-release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sakshi1215 @zdtsw @karianna